linux-kernel - Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 10:42:35 +0800
From:   liulongfang <liulongfang@...wei.com>
To:     Alan Stern <stern@...land.harvard.edu>
CC:     <gregkh@...uxfoundation.org>, <mathias.nyman@...el.com>,
        <liudongdong3@...wei.com>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kong.kongxinwei@...ilicon.com>,
        <yisen.zhuang@...wei.com>
Subject: Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem

On 2021/4/8 22:53, Alan Stern wrote:
> On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote:
>> (1) Add a whitelist for EHCI devices without SBRN registers.
>> (2) Add Kunpeng920's EHCI device to the whitelist.
>>
>> Changes in v2:
>> 	- Fix some code style issues.
>> 	- Update function name.
>>
>> Longfang Liu (2):
>>   USB:ehci:Add a whitelist for EHCI controllers
>>   USB:ehci:fix Kunpeng920 ehci hardware problem
>>
>>  drivers/usb/host/ehci-pci.c | 30 ++++++++++++++++++++++++++----
>>  1 file changed, 26 insertions(+), 4 deletions(-)
> 
> I don't think we need a whole list, along with an associated lookup 
> routine, when there are only two entries.  The total amount of code will 
> be smaller if you just add a check for the Kunpeng920 controller to
> the existing check for the STMICRO controller.
> 
> Alan Stern
> .
> 
Now there are two EHCI controllers that do not have SBRN registers,
and there may be more in the future. This list is added for subsequent
compatibility if there are such controllers, instead of a series of if-else.
Thanks.
Longfang.