linux-kernel - [PATCH v1 5/8] scsi: megaraid: clean up for "foo * bar"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Apr 2021 14:48:04 +0800
From:   Luo Jiaxing <luojiaxing@...wei.com>
To:     <kashyap.desai@...adcom.com>, <sumit.saxena@...adcom.com>,
        <shivasharan.srikanteshwara@...adcom.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <megaraidlinux.pdl@...adcom.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <luojiaxing@...wei.com>
Subject: [PATCH v1 5/8] scsi: megaraid: clean up for "foo * bar"

Following error is reported by checkpatch.pl:

"foo * bar" should be "foo *bar"
+                     struct megasas_iocpacket __user * user_ioc,

The format of the pointer variable must be "foo *bar", so fix
them.

Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>
---
 drivers/scsi/megaraid/megaraid_ioctl.h    | 4 ++--
 drivers/scsi/megaraid/megaraid_mbox.h     | 2 +-
 drivers/scsi/megaraid/megaraid_mm.c       | 4 ++--
 drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_ioctl.h b/drivers/scsi/megaraid/megaraid_ioctl.h
index 87b880fe..9bc0250 100644
--- a/drivers/scsi/megaraid/megaraid_ioctl.h
+++ b/drivers/scsi/megaraid/megaraid_ioctl.h
@@ -126,7 +126,7 @@ typedef struct uioc {
 	uint8_t			reserved[128];
 
 /* Driver Data: */
-	void __user *		user_data;
+	void __user		*user_data;
 	uint32_t		user_data_len;
 
 	/* 64bit alignment */
@@ -138,7 +138,7 @@ typedef struct uioc {
 	dma_addr_t		pthru32_h;
 
 	struct list_head	list;
-	void			(*done)(struct uioc*);
+	void			(*done)(struct uioc *);
 
 	caddr_t			buf_vaddr;
 	dma_addr_t		buf_paddr;
diff --git a/drivers/scsi/megaraid/megaraid_mbox.h b/drivers/scsi/megaraid/megaraid_mbox.h
index d2fe7f6..3c16d38 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.h
+++ b/drivers/scsi/megaraid/megaraid_mbox.h
@@ -189,7 +189,7 @@ typedef struct {
 	dma_addr_t			mbox_dma;
 	spinlock_t			mailbox_lock;
 	unsigned long			baseport;
-	void __iomem *			baseaddr;
+	void __iomem			*baseaddr;
 	struct mraid_pci_blk		mbox_pool[MBOX_MAX_SCSI_CMDS];
 	struct dma_pool			*mbox_pool_handle;
 	struct mraid_pci_blk		epthru_pool[MBOX_MAX_SCSI_CMDS];
diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c
index 864cbb6..234885c 100644
--- a/drivers/scsi/megaraid/megaraid_mm.c
+++ b/drivers/scsi/megaraid/megaraid_mm.c
@@ -582,7 +582,7 @@ static uioc_t *
 mraid_mm_alloc_kioc(mraid_mmadp_t *adp)
 {
 	uioc_t			*kioc;
-	struct list_head*	head;
+	struct list_head	*head;
 	unsigned long		flags;
 
 	down(&adp->kioc_semaphore);
@@ -722,7 +722,7 @@ ioctl_done(uioc_t *kioc)
 {
 	uint32_t	adapno;
 	int		iterator;
-	mraid_mmadp_t*	adapter;
+	mraid_mmadp_t	*adapter;
 
 	/*
 	 * When the kioc returns from driver, make sure it still doesn't
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 40c77bb..2b17529 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4402,7 +4402,7 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
 	 * Allocate the dynamic array first and then allocate individual
 	 * commands.
 	 */
-	instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd*), GFP_KERNEL);
+	instance->cmd_list = kcalloc(max_cmd, sizeof(struct megasas_cmd *), GFP_KERNEL);
 
 	if (!instance->cmd_list) {
 		dev_printk(KERN_DEBUG, &instance->pdev->dev, "out of memory\n");
@@ -8150,7 +8150,7 @@ static int megasas_set_crash_dump_params_ioctl(struct megasas_cmd *cmd)
  */
 static int
 megasas_mgmt_fw_ioctl(struct megasas_instance *instance,
-		      struct megasas_iocpacket __user * user_ioc,
+		      struct megasas_iocpacket __user *user_ioc,
 		      struct megasas_iocpacket *ioc)
 {
 	struct megasas_sge64 *kern_sge64 = NULL;
-- 
2.7.4