linux-kernel - Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192e: replace comparison to NULL by boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2104101015560.2975@hadrien>
Date:   Sat, 10 Apr 2021 10:16:19 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Mitali Borkar <mitaliborkar810@...il.com>
cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        mitali_s@...iitr.ac.in
Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192e: replace
 comparison to NULL by boolean



On Sat, 10 Apr 2021, Mitali Borkar wrote:

> Replaced comparison to NULL by boolean expressions
> (here used boolean negations). This improves readability of code.
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 65202dd53447..0b1e92f17805 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
>  	struct rt_hi_throughput *pHT = ieee->pHTInfo;
>  	struct ht_capab_ele *pCapELE = NULL;
>
> -	if ((posHTCap == NULL) || (pHT == NULL)) {
> +	if ((!posHTCap) || (!pHT)) {

You can drop the parentheses. ! has higher precedenace than ||.

julia

>  		netdev_warn(ieee->dev,
>  			    "%s(): posHTCap and pHTInfo are null\n", __func__);
>  		return;
> @@ -357,7 +357,7 @@ void HTConstructInfoElement(struct rtllib_device *ieee, u8 *posHTInfo,
>  	struct rt_hi_throughput *pHT = ieee->pHTInfo;
>  	struct ht_info_ele *pHTInfoEle = (struct ht_info_ele *)posHTInfo;
>
> -	if ((posHTInfo == NULL) || (pHTInfoEle == NULL)) {
> +	if ((!posHTInfo) || (!pHTInfoEle)) {
>  		netdev_warn(ieee->dev,
>  			    "%s(): posHTInfo and pHTInfoEle are null\n",
>  			    __func__);
> @@ -397,7 +397,7 @@ void HTConstructInfoElement(struct rtllib_device *ieee, u8 *posHTInfo,
>  void HTConstructRT2RTAggElement(struct rtllib_device *ieee, u8 *posRT2RTAgg,
>  				u8 *len)
>  {
> -	if (posRT2RTAgg == NULL) {
> +	if (!posRT2RTAgg) {
>  		netdev_warn(ieee->dev, "%s(): posRT2RTAgg is null\n", __func__);
>  		return;
>  	}
> @@ -420,7 +420,7 @@ static u8 HT_PickMCSRate(struct rtllib_device *ieee, u8 *pOperateMCS)
>  {
>  	u8 i;
>
> -	if (pOperateMCS == NULL) {
> +	if (!pOperateMCS) {
>  		netdev_warn(ieee->dev, "%s(): pOperateMCS is null\n", __func__);
>  		return false;
>  	}
> @@ -453,7 +453,7 @@ u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
>  	u8		mcsRate = 0;
>  	u8		availableMcsRate[16];
>
> -	if (pMCSRateSet == NULL || pMCSFilter == NULL) {
> +	if (!pMCSRateSet || !pMCSFilter) {
>  		netdev_warn(ieee->dev,
>  			    "%s(): pMCSRateSet and pMCSFilter are null\n",
>  			    __func__);
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHEJngq5MHBEspGY%40kali.
>