linux-kernel - Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e76d59f9-37ff-b31e-0131-113a1eedd786@denx.de>
Date:   Sat, 10 Apr 2021 15:20:57 +0200
From:   Marek Vasut <marex@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        stable@...r.kernel.org, Roman Guskov <rguskov@...electronics.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware
 node

On 4/10/21 2:07 PM, Greg Kroah-Hartman wrote:
> On Sat, Apr 10, 2021 at 11:09:19AM +0200, Bartosz Golaszewski wrote:
>> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> On STM32MP1, the GPIO banks are subnodes of pin-controller@...02000,
>> see arch/arm/boot/dts/stm32mp151.dtsi. The driver for
>> pin-controller@...02000 is in drivers/pinctrl/stm32/pinctrl-stm32.c
>> and iterates over all of its DT subnodes when registering each GPIO
>> bank gpiochip. Each gpiochip has:
>>
>>    - gpio_chip.parent = dev,
>>      where dev is the device node of the pin controller
>>    - gpio_chip.of_node = np,
>>      which is the OF node of the GPIO bank
>>
>> Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node),
>> i.e. pin-controller@...02000 != pin-controller@...02000/gpio@...0*000.
>>
>> The original code behaved correctly, as it extracted the "gpio-line-names"
>> from of_fwnode_handle(chip.of_node) = pin-controller@...02000/gpio@...0*000.
>>
>> To achieve the same behaviour, read property from the firmware node.
>>
>> Fixes: 7cba1a4d5e162 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties")
>> Cc: stable@...r.kernel.org
>> Reported-by: Marek Vasut <marex@...x.de>
>> Reported-by: Roman Guskov <rguskov@...electronics.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Tested-by: Marek Vasut <marex@...x.de>
>> Reviewed-by: Marek Vasut <marex@...x.de>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
>> ---
>> Hi Greg,
>>
>> This patch somehow got lost and never made its way into stable. Could you
>> please apply it?
> 
> This has been added and removed more times than I can remember already.
> 
> Are you all _SURE_ this is safe for a stable kernel release?  Look in
> the archives for complaints when we added this in the past.

I now tested this on stm32mp1, which was the original platform that got 
affected by the problem this is supposed to fix, and I can confirm this 
patch fixes the problem there.

So for what it's worth
Tested-by: Marek Vasut <marex@...x.de> # on stm32mp1