linux-kernel - Re: [PATCH] staging: rtl8723bs: remove unnecessary goto jumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Apr 2021 22:49:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bryan Brattlof <hello@...anbrattlof.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Larry Finger <Larry.Finger@...inger.net>
Cc:     kbuild-all@...ts.01.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Bryan Brattlof <hello@...anbrattlof.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary goto jumps

Hi Bryan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Bryan-Brattlof/staging-rtl8723bs-remove-unnecessary-goto-jumps/20210410-213334
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 32abcac8037da5dc570c22abf266cbb92eee9fc9
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/244bc6c6b650db830cbd316043711fda4f2f34d9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bryan-Brattlof/staging-rtl8723bs-remove-unnecessary-goto-jumps/20210410-213334
        git checkout 244bc6c6b650db830cbd316043711fda4f2f34d9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/staging/rtl8723bs/os_dep/sdio_intf.c: In function 'rtw_drv_entry':
>> drivers/staging/rtl8723bs/os_dep/sdio_intf.c:522:2: error: implicit declaration of function 'DBG_870X_LEVEL'; did you mean 'DBG_871X_LEVEL'? [-Werror=implicit-function-declaration]
     522 |  DBG_870X_LEVEL(_drv_always_, "module init ret =%d\n", ret);
         |  ^~~~~~~~~~~~~~
         |  DBG_871X_LEVEL
   cc1: some warnings being treated as errors


vim +522 drivers/staging/rtl8723bs/os_dep/sdio_intf.c

   513	
   514		sdio_drvpriv.drv_registered = true;
   515	
   516		ret = sdio_register_driver(&sdio_drvpriv.r871xs_drv);
   517		if (ret != 0) {
   518			sdio_drvpriv.drv_registered = false;
   519			rtw_ndev_notifier_unregister();
   520		}
   521	
 > 522		DBG_870X_LEVEL(_drv_always_, "module init ret =%d\n", ret);
   523		return ret;
   524	}
   525	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (69034 bytes)