linux-kernel - Re: [Outreachy kernel] [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Apr 2021 12:07:40 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Mitali Borkar <mitaliborkar810@...il.com>
cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com,
        mitali_s@...iitr.ac.in
Subject: Re: [Outreachy kernel] [PATCH v3 1/3] staging: rtl8192e: remove
 parentheses around boolean expression



On Sun, 11 Apr 2021, Mitali Borkar wrote:

> Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher
> precedance than '||'

The log message is too wide.  It should be at most around 70 characters
wide, because git will indent it a little.

julia


>
> Signed-off-by: Mitali Borkar <mitaliborkar810@...il.com>
> ---
>
> Changes from v2:- Modified subject description.
> Changes from v1:- Removed unnecessary parentheses around boolean expression.
> Changes has been made in v2.
>
>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index b1fa8e9a4f28..431202927036 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
>  	struct rt_hi_throughput *pHT = ieee->pHTInfo;
>  	struct ht_capab_ele *pCapELE = NULL;
>
> -	if ((!posHTCap) || (!pHT)) {
> +	if (!posHTCap || !pHT) {
>  		netdev_warn(ieee->dev,
>  			    "%s(): posHTCap and pHTInfo are null\n", __func__);
>  		return;
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/30a330377667aa5043a60ed3cdf1bbb37099631c.1618133351.git.mitaliborkar810%40gmail.com.
>