[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGOxZ51PKMZoPyk-kidGRr7zNvADfjAJG8LtMMBOi0vn-KBsLA@mail.gmail.com>
Date: Sun, 11 Apr 2021 18:25:58 +0530
From: Alim Akhtar <alim.akhtar@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment
On Sat, Apr 10, 2021 at 10:18 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> The initialization of 'ret' variable in probe function is shortly after
> overwritten. This initialization is simply not used.
>
> Addresses-Coverity: Unused value
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
Thanks Krzysztof,
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>
> drivers/iio/adc/exynos_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 784c10deeb1a..2d8e36408f0e 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> struct iio_dev *indio_dev = NULL;
> bool has_ts = false;
> - int ret = -ENODEV;
> + int ret;
> int irq;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));
> --
> 2.25.1
>
--
Regards,
Alim
Powered by blists - more mailing lists