linux-kernel - Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Apr 2021 21:07:22 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Puranjay Mohan <puranjay12@...il.com>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>,
        devicetree <devicetree@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v4 2/2] iio: temperature: add driver support for ti tmp117

On Sun, Apr 11, 2021 at 5:53 PM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Wed,  7 Apr 2021 23:51:47 +0530
> Puranjay Mohan <puranjay12@...il.com> wrote:
>
> > TMP117 is a Digital temperature sensor with integrated Non-Volatile memory.
> > Add support for tmp117 driver in iio subsystem.

...

> > +             off = clamp(val, S16_MIN, S16_MAX);
>
> With a C=1 W=1 build (sparse an lots of warnings) this causes problems because
> the S16_MIN and S16_MAX are as you might imagine s16 values whereas val is
> an int.  I've added casts to force S16_MIN and S16_MAX to ints as well.

Good point, but better is to use clamp_t(s16, ...) rather than explicit casting.
I always consider explicit casting in C (and esp. in Linux kernel) is
a red flag. Should be really rarely needed.

> > +             if (off == data->calibbias)
> > +                     return 0;

-- 
With Best Regards,
Andy Shevchenko