linux-kernel - 答复: [PATCH v1 01/14] vfio: Create vfio_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Apr 2021 04:03:24 +0000
From:   "Zengtao (B)" <prime.zeng@...ilicon.com>
To:     Jason Gunthorpe <jgg@...dia.com>,
        Alex Williamson <alex.williamson@...hat.com>
CC:     "cohuck@...hat.com" <cohuck@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterx@...hat.com" <peterx@...hat.com>
Subject: 答复: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device

> -----邮件原件-----
> 发件人: Jason Gunthorpe [mailto:jgg@...dia.com]
> 发送时间: 2021年4月10日 1:32
> 收件人: Alex Williamson <alex.williamson@...hat.com>
> 抄送: Zengtao (B) <prime.zeng@...ilicon.com>; cohuck@...hat.com;
> kvm@...r.kernel.org; linux-kernel@...r.kernel.org; peterx@...hat.com
> 主题: Re: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device
> 
> On Fri, Apr 09, 2021 at 08:24:00AM -0600, Alex Williamson wrote:
> 
> > > >  #define DRIVER_VERSION	"0.3"
> > > >  #define DRIVER_AUTHOR	"Alex Williamson
> <alex.williamson@...hat.com>"
> > > >  #define DRIVER_DESC	"VFIO - User Level meta-driver"
> > > >
> > > > +#define VFIO_MAGIC 0x5646494f /* "VFIO" */
> > > Move to include/uapi/linux/magic.h ?
> >
> > Hmm, yeah, I suppose it probably should go there.  Thanks.
> 
> From my review we haven't been doing that unless it is actually uapi relavent
> for some reason (this is not)
>
Yes, it's not uapi relavent, and I still think it's better to put magic
 in a single header, and currently not all micros in magic.h are for
 uapi, some work should be done for that, but no ideas now, :)
 
> In particular with CH having a patch series to eliminate all of these cases and
> drop the constants..
> 
Interested, could you share the links for that?

Thanks 
Zengtao 

> Jason