linux-kernel - Re: [PATCH 1/2] kbuild: dummy-tools: Add elfedit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210412124652.GT6564@kitsune.suse.cz>
Date:   Mon, 12 Apr 2021 14:46:52 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] kbuild: dummy-tools: Add elfedit.

On Sun, Apr 11, 2021 at 08:37:03PM +0900, Masahiro Yamada wrote:
> On Sun, Apr 11, 2021 at 7:18 PM Michal Suchánek <msuchanek@...e.de> wrote:
> >
> > On Sun, Apr 11, 2021 at 03:12:40AM +0900, Masahiro Yamada wrote:
> > > On Fri, Apr 9, 2021 at 6:31 AM Michal Suchanek <msuchanek@...e.de> wrote:
> > > >
> > > > elfedit is used in Makefile
> > > >
> > > >  Makefile:GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit))
> > > >
> > > > which causes this error getting printed
> > > >
> > > >  which: no elfedit in (./scripts/dummy-tools)
> > >
> > >
> > > I am OK with this patch, but how did you reproduce it?
> >
> > make ARCH=arm CROSS_COMPILE=scripts/dummy-tools/ allmodconfig
> >
> > it possibly depends on the config you already have, too.
> >
> > Thanks
> >
> > Michal
> 
> 
> Maybey, are you working on linux-next?
> 
> 
> [1]
> $ git checkout  add74f8473^
> $ make ARCH=arm CROSS_COMPILE=scripts/dummy-tools/ allmodconfig
> 
> [2]
> $ git checkout  add74f8473
> $ make ARCH=arm CROSS_COMPILE=scripts/dummy-tools/ allmodconfig

Indeed, the rust support is the cause of the issue:

add74f8473c5ca7d8947c760ff355df991a259bb (HEAD) Rust support
0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b (tag: v5.12-rc4, s390/master,
s390/linux/master) Linux 5.12-rc4

While v5.12-rc4 is OK add74f8473 produces the error.

There is additional issue that I noticed: dummy tools does not work
seamlessly with O=

$ make CROSS_COMPILE=$(pwd)/scripts/dummy-tools/ O=/scratch/ppc64/ V=1 ARCH=powerpc allmodconfig > /dev/null
which: no elfedit in (/home/michal/linux-2.6/scripts/dummy-tools)

$ make CROSS_COMPILE=scripts/dummy-tools/ O=/scratch/ppc64/ V=1 ARCH=powerpc allmodconfig > /dev/null
which: no elfedit in (./scripts/dummy-tools)
scripts/Kconfig.include:39: compiler 'scripts/dummy-tools/gcc' not found
make[2]: *** [/home/michal/linux-2.6/scripts/kconfig/Makefile:63:
allmodconfig] Error 1
make[1]: *** [/home/michal/linux-2.6/Makefile:636: allmodconfig] Error 2
make: *** [Makefile:222: __sub-make] Error 2

Perhaps linking dummy-tools into the target directory would be a good
idea?

Thanks

Michal