linux-kernel - Re: [PATCH] staging: fieldbus: simplify devm_anybuss_host_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b23680d9-f1b8-f458-9d6b-c10f14d13eca@huawei.com>
Date:   Mon, 12 Apr 2021 21:05:12 +0800
From:   "tiantao (H)" <tiantao6@...wei.com>
To:     Sven Van Asbroeck <thesven73@...il.com>
CC:     Tian Tao <tiantao6@...ilicon.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: fieldbus: simplify
 devm_anybuss_host_common_probe


在 2021/4/12 20:40, Sven Van Asbroeck 写道:
> On Sun, Apr 11, 2021 at 9:14 PM tiantao (H) <tiantao6@...wei.com> wrote:
>> What about doing it like this?
>>
>> -static void host_release(struct device *dev, void *res)
>> +static void host_release(void *res)
>>    {
>> -       struct anybuss_host **dr = res;
>> -
>> -       anybuss_host_common_remove(*dr);
>> +       anybuss_host_common_remove(res);
>>    }
> That looks like it could work. Can you resend as a "proper" patch,
> please? To tell the versions apart, simply specify [PATCH v1] [PATCH
> v2] etc in the patch title/subject line. Then below the patch's "---
> line", add the version history.
> .
sure. thanks for helping review。