linux-kernel - Re: [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YHRGhQ51LeouoWEv@hovoldconsulting.com>
Date:   Mon, 12 Apr 2021 15:09:25 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     gregkh@...uxfoundation.org, Alan Stern <stern@...land.harvard.edu>,
        penghao <penghao@...ontech.com>,
        Oliver Neukum <oneukum@...e.com>,
        Jonathan Cox <jonathan@...ox.net>,
        Kars Mulder <kerneldev@...smulder.nl>,
        Tomasz Meresiński <tomasz@...esinski.eu>,
        "open list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock
 Gen2 Ethernet

On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote:
> This is another branded 8153 device that doesn't work well with LPM
> enabled:
> [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71
> 
> So disable LPM to resolve the issue.
> 
> BugLink: https://bugs.launchpad.net/bugs/1922651
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> v2:
>  - Put the quirk in the right order.

Seriously... You sent the exact same patch again. Still not ordered.

> 
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 76ac5d6555ae..dfedb51cf832 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	{ USB_DEVICE(0x1532, 0x0116), .driver_info =
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>  
> +	/* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */
> +	{ USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM },
> +
>  	/* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
>  	{ USB_DEVICE(0x17ef, 0xa012), .driver_info =
>  			USB_QUIRK_DISCONNECT_SUSPEND },

Johan