linux-kernel - Re: Subject: [PATCH] staging: media: meson: vdec: declare u32 as static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202104130009.XdleSNds-lkp@intel.com>
Date:   Tue, 13 Apr 2021 00:45:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mitali Borkar <mitaliborkar810@...il.com>, narmstrong@...libre.com,
        mchehab@...nel.org, gregkh@...uxfoundation.org,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com
Cc:     kbuild-all@...ts.01.org, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: Subject: [PATCH] staging: media: meson: vdec: declare u32 as
 static const

Hi Mitali,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Mitali-Borkar/Subject-PATCH-staging-media-meson-vdec-declare-u32-as-static-const/20210412-222025
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c9873622761b42d977b48804bb0b4b9a7fbcd6b3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mitali-Borkar/Subject-PATCH-staging-media-meson-vdec-declare-u32-as-static-const/20210412-222025
        git checkout c9873622761b42d977b48804bb0b4b9a7fbcd6b3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   drivers/staging/media/meson/vdec/codec_h264.c: In function 'codec_h264_resume':
>> drivers/staging/media/meson/vdec/codec_h264.c:290:18: error: expected identifier or '(' before '[' token
     290 |  static const u32[] canvas3 = { ANCO_CANVAS_ADDR, 0 };
         |                  ^
   drivers/staging/media/meson/vdec/codec_h264.c:291:18: error: expected identifier or '(' before '[' token
     291 |  static const u32[] canvas4 = { 24, 0 };
         |                  ^
>> drivers/staging/media/meson/vdec/codec_h264.c:291:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     291 |  static const u32[] canvas4 = { 24, 0 };
         |  ^~~~~~
>> drivers/staging/media/meson/vdec/codec_h264.c:293:28: error: 'canvas3' undeclared (first use in this function)
     293 |  amvdec_set_canvases(sess, canvas3, canvas4);
         |                            ^~~~~~~
   drivers/staging/media/meson/vdec/codec_h264.c:293:28: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/staging/media/meson/vdec/codec_h264.c:293:37: error: 'canvas4' undeclared (first use in this function)
     293 |  amvdec_set_canvases(sess, canvas3, canvas4);
         |                                     ^~~~~~~


vim +290 drivers/staging/media/meson/vdec/codec_h264.c

   284	
   285	static void codec_h264_resume(struct amvdec_session *sess)
   286	{
   287		struct amvdec_core *core = sess->core;
   288		struct codec_h264 *h264 = sess->priv;
   289		u32 mb_width, mb_height, mb_total;
 > 290		static const u32[] canvas3 = { ANCO_CANVAS_ADDR, 0 };
 > 291		static const u32[] canvas4 = { 24, 0 };
   292	
 > 293		amvdec_set_canvases(sess, canvas3, canvas4);
   294	
   295		dev_dbg(core->dev, "max_refs = %u; actual_dpb_size = %u\n",
   296			h264->max_refs, sess->num_dst_bufs);
   297	
   298		/* Align to a multiple of 4 macroblocks */
   299		mb_width = ALIGN(h264->mb_width, 4);
   300		mb_height = ALIGN(h264->mb_height, 4);
   301		mb_total = mb_width * mb_height;
   302	
   303		h264->ref_size = mb_total * MB_MV_SIZE * h264->max_refs;
   304		h264->ref_vaddr = dma_alloc_coherent(core->dev, h264->ref_size,
   305						     &h264->ref_paddr, GFP_KERNEL);
   306		if (!h264->ref_vaddr) {
   307			amvdec_abort(sess);
   308			return;
   309		}
   310	
   311		/* Address to store the references' MVs */
   312		amvdec_write_dos(core, AV_SCRATCH_1, h264->ref_paddr);
   313		/* End of ref MV */
   314		amvdec_write_dos(core, AV_SCRATCH_4, h264->ref_paddr + h264->ref_size);
   315	
   316		amvdec_write_dos(core, AV_SCRATCH_0, (h264->max_refs << 24) |
   317						     (sess->num_dst_bufs << 16) |
   318						     ((h264->max_refs - 1) << 8));
   319	}
   320	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (63844 bytes)