linux-kernel - Re: [PATCH] mm/compaction:let proactive compaction order configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202104130246.ahXkmT7R-lkp@intel.com>
Date:   Tue, 13 Apr 2021 02:53:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     chukaiping <chukaiping@...du.com>, mcgrof@...nel.org,
        keescook@...omium.org, yzaikin@...gle.com,
        akpm@...ux-foundation.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm/compaction:let proactive compaction order configurable

Hi chukaiping,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kees/for-next/pstore]
[also build test ERROR on linus/master v5.12-rc7 next-20210412]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/chukaiping/mm-compaction-let-proactive-compaction-order-configurable/20210412-172336
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
config: powerpc-cell_defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a203321bf356e9514ca678c96119df72d6bfa803
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review chukaiping/mm-compaction-let-proactive-compaction-order-configurable/20210412-172336
        git checkout a203321bf356e9514ca678c96119df72d6bfa803
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/include/asm/mmu.h:149,
                    from arch/powerpc/include/asm/lppaca.h:46,
                    from arch/powerpc/include/asm/paca.h:17,
                    from arch/powerpc/include/asm/current.h:13,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from include/linux/node.h:18,
                    from include/linux/cpu.h:17,
                    from mm/compaction.c:11:
>> arch/powerpc/include/asm/page.h:39:28: error: initializer element is not constant
      39 | #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT)
         |                            ^
   mm/compaction.c:66:32: note: in expansion of macro 'HUGETLB_PAGE_ORDER'
      66 | #define COMPACTION_HPAGE_ORDER HUGETLB_PAGE_ORDER
         |                                ^~~~~~~~~~~~~~~~~~
   mm/compaction.c:2669:54: note: in expansion of macro 'COMPACTION_HPAGE_ORDER'
    2669 | unsigned int __read_mostly sysctl_compaction_order = COMPACTION_HPAGE_ORDER;
         |                                                      ^~~~~~~~~~~~~~~~~~~~~~


vim +39 arch/powerpc/include/asm/page.h

5cd16ee934eafc include/asm-powerpc/page.h      Michael Ellerman 2005-11-11  25  
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  26  #ifndef __ASSEMBLY__
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  27  #ifndef CONFIG_HUGETLB_PAGE
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  28  #define HPAGE_SHIFT PAGE_SHIFT
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  29  #elif defined(CONFIG_PPC_BOOK3S_64)
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  30  extern unsigned int hpage_shift;
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  31  #define HPAGE_SHIFT hpage_shift
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  32  #elif defined(CONFIG_PPC_8xx)
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  33  #define HPAGE_SHIFT		19	/* 512k pages */
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  34  #elif defined(CONFIG_PPC_FSL_BOOK3E)
c5710cd2073503 arch/powerpc/include/asm/page.h Christophe Leroy 2019-04-26  35  #define HPAGE_SHIFT		22	/* 4M pages */
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  36  #endif
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  37  #define HPAGE_SIZE		((1UL) << HPAGE_SHIFT)
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  38  #define HPAGE_MASK		(~(HPAGE_SIZE - 1))
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28 @39  #define HUGETLB_PAGE_ORDER	(HPAGE_SHIFT - PAGE_SHIFT)
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  40  #define HUGE_MAX_HSTATE		(MMU_PAGE_COUNT-1)
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  41  #endif
41151e77a4d96e arch/powerpc/include/asm/page.h Becky Bruce      2011-06-28  42  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (21251 bytes)