| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Apr 2021 12:45:17 -0700
From: Steve Rutherford <srutherford@...gle.com>
To: kernel test robot <lkp@...el.com>
Cc: KVM list <kvm@...r.kernel.org>, kbuild-all@...ts.01.org,
LKML <linux-kernel@...r.kernel.org>,
Nathan Tempelman <natet@...gle.com>,
Ashish Kalra <Ashish.Kalra@....com>,
Brijesh Singh <brijesh.singh@....com>,
Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v2] KVM: SVM: Add support for KVM_SEV_SEND_CANCEL command
On Sun, Apr 11, 2021 at 1:56 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Steve,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on kvm/queue]
> [also build test ERROR on vhost/linux-next cryptodev/master linux/master linus/master v5.12-rc6 next-20210409]
> [cannot apply to crypto/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Steve-Rutherford/KVM-SVM-Add-support-for-KVM_SEV_SEND_CANCEL-command/20210410-060941
> base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
> config: x86_64-allyesconfig (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
> # https://github.com/0day-ci/linux/commit/16f9122ec5c3ee772f1edb80c2c2526650b60868
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Steve-Rutherford/KVM-SVM-Add-support-for-KVM_SEV_SEND_CANCEL-command/20210410-060941
> git checkout 16f9122ec5c3ee772f1edb80c2c2526650b60868
> # save the attached .config to linux build tree
> make W=1 ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/crypto/ccp/sev-dev.c: In function 'sev_cmd_buffer_len':
> >> drivers/crypto/ccp/sev-dev.c:132:7: error: 'SEV_SEND_CANCEL' undeclared (first use in this function); did you mean 'SEV_CMD_SEND_CANCEL'?
> 132 | case SEV_SEND_CANCEL: return sizeof(struct sev_data_send_cancel);
> | ^~~~~~~~~~~~~~~
> | SEV_CMD_SEND_CANCEL
> drivers/crypto/ccp/sev-dev.c:132:7: note: each undeclared identifier is reported only once for each function it appears in
>
>
> vim +132 drivers/crypto/ccp/sev-dev.c
>
> 100
> 101 static int sev_cmd_buffer_len(int cmd)
> 102 {
> 103 switch (cmd) {
> 104 case SEV_CMD_INIT: return sizeof(struct sev_data_init);
> 105 case SEV_CMD_PLATFORM_STATUS: return sizeof(struct sev_user_data_status);
> 106 case SEV_CMD_PEK_CSR: return sizeof(struct sev_data_pek_csr);
> 107 case SEV_CMD_PEK_CERT_IMPORT: return sizeof(struct sev_data_pek_cert_import);
> 108 case SEV_CMD_PDH_CERT_EXPORT: return sizeof(struct sev_data_pdh_cert_export);
> 109 case SEV_CMD_LAUNCH_START: return sizeof(struct sev_data_launch_start);
> 110 case SEV_CMD_LAUNCH_UPDATE_DATA: return sizeof(struct sev_data_launch_update_data);
> 111 case SEV_CMD_LAUNCH_UPDATE_VMSA: return sizeof(struct sev_data_launch_update_vmsa);
> 112 case SEV_CMD_LAUNCH_FINISH: return sizeof(struct sev_data_launch_finish);
> 113 case SEV_CMD_LAUNCH_MEASURE: return sizeof(struct sev_data_launch_measure);
> 114 case SEV_CMD_ACTIVATE: return sizeof(struct sev_data_activate);
> 115 case SEV_CMD_DEACTIVATE: return sizeof(struct sev_data_deactivate);
> 116 case SEV_CMD_DECOMMISSION: return sizeof(struct sev_data_decommission);
> 117 case SEV_CMD_GUEST_STATUS: return sizeof(struct sev_data_guest_status);
> 118 case SEV_CMD_DBG_DECRYPT: return sizeof(struct sev_data_dbg);
> 119 case SEV_CMD_DBG_ENCRYPT: return sizeof(struct sev_data_dbg);
> 120 case SEV_CMD_SEND_START: return sizeof(struct sev_data_send_start);
> 121 case SEV_CMD_SEND_UPDATE_DATA: return sizeof(struct sev_data_send_update_data);
> 122 case SEV_CMD_SEND_UPDATE_VMSA: return sizeof(struct sev_data_send_update_vmsa);
> 123 case SEV_CMD_SEND_FINISH: return sizeof(struct sev_data_send_finish);
> 124 case SEV_CMD_RECEIVE_START: return sizeof(struct sev_data_receive_start);
> 125 case SEV_CMD_RECEIVE_FINISH: return sizeof(struct sev_data_receive_finish);
> 126 case SEV_CMD_RECEIVE_UPDATE_DATA: return sizeof(struct sev_data_receive_update_data);
> 127 case SEV_CMD_RECEIVE_UPDATE_VMSA: return sizeof(struct sev_data_receive_update_vmsa);
> 128 case SEV_CMD_LAUNCH_UPDATE_SECRET: return sizeof(struct sev_data_launch_secret);
> 129 case SEV_CMD_DOWNLOAD_FIRMWARE: return sizeof(struct sev_data_download_firmware);
> 130 case SEV_CMD_GET_ID: return sizeof(struct sev_data_get_id);
> 131 case SEV_CMD_ATTESTATION_REPORT: return sizeof(struct sev_data_attestation_report);
> > 132 case SEV_SEND_CANCEL: return sizeof(struct sev_data_send_cancel);
> 133 default: return 0;
> 134 }
> 135
> 136 return 0;
> 137 }
> 138
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Ugh, forgot to amend. V3 sent.
Powered by blists - more mailing lists