linux-kernel - Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vfq38EqN4qQQnZB_m71sE=uj5vWbDdkdXX7C8kNoLwwOQ@mail.gmail.com>
Date:   Tue, 13 Apr 2021 02:34:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Wolfram Sang <wsa@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

On Tue, Apr 13, 2021 at 2:21 AM Chris Packham
<Chris.Packham@...iedtelesis.co.nz> wrote:
> On 13/04/21 10:52 am, Andy Shevchenko wrote:
> > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
> > <chris.packham@...iedtelesis.co.nz> wrote:
> >> Use device managed functions an clean up error handling.
> > For the god sake how have you tested this?
> > The patch is broken.
> I've clearly missed the remove path in my testing. I was focused on the
> interrupt bevhaviour not the probe/remove which I'll make sure to check
> for the next round.

Thanks. And you may also remove forward declaration of IDs and
probably some other leftovers (Cc me for the next round, I'll help to
review).


-- 
With Best Regards,
Andy Shevchenko