linux-kernel - Re: [PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d89bd95c-df22-9edd-e48e-0ac19cf1590b@hisilicon.com>
Date:   Mon, 12 Apr 2021 09:54:20 +0800
From:   Shaokun Zhang <zhangshaokun@...ilicon.com>
To:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Yang Guo <guoyang2@...wei.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/buffer.c: Delete redundant uptodate check for buffer

+Cc: Andrew Morton

On 2021/4/1 14:57, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@...wei.com>
> 
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
> 
> Cc: Alexander Viro <viro@...iv.linux.org.uk> 
> Signed-off-by: Yang Guo <guoyang2@...wei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>
> ---
>  fs/buffer.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 673cfbef9eec..2c0d0b3f3203 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2055,8 +2055,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>  		block_end = block_start + blocksize;
>  		if (block_end <= from || block_start >= to) {
>  			if (PageUptodate(page)) {
> -				if (!buffer_uptodate(bh))
> -					set_buffer_uptodate(bh);
> +				set_buffer_uptodate(bh);
>  			}
>  			continue;
>  		}
> @@ -2088,8 +2087,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>  			}
>  		}
>  		if (PageUptodate(page)) {
> -			if (!buffer_uptodate(bh))
> -				set_buffer_uptodate(bh);
> +			set_buffer_uptodate(bh);
>  			continue; 
>  		}
>  		if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
>