linux-kernel - Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210412030458.t2vhg4nxwyi5yp4o@toshiba.co.jp>
Date:   Mon, 12 Apr 2021 12:04:58 +0900
From:   Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>, devicetree@...r.kernel.org,
        linux-pwm@...r.kernel.org, punit1.agrawal@...hiba.co.jp,
        yuji2.ishikawa@...hiba.co.jp, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM
 support

Hi,

On Sat, Apr 10, 2021 at 08:52:22PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> one more comment:
> 
> On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote:
> > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip *chip)
> 
> all functions but this one start have the common prefix "visconti_pwm_".
> I like the concept of a common prefix and so you could rename this
> function to visconti_pwm_from_chip or similar.

OK, I will change. 

> 
> Best regards
> Uwe
> 

Best regards,
  Nobuhiro