linux-kernel - [PATCH] thermal: tmon: Remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 12 Apr 2021 17:35:22 +0800
From:   Wan Jiabing <wanjiabing@...o.com>
To:     rui.zhang@...el.com, daniel.lezcano@...aro.org, amitk@...nel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net, Wan Jiabing <wanjiabing@...o.com>
Subject: [PATCH] thermal: tmon: Remove unneeded variable

Fix coccicheck warning:

tools/thermal/tmon/pid.c:57:5-8:
Unneeded variable: ret. Return 0 on line 68

Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
---
 tools/thermal/tmon/pid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/thermal/tmon/pid.c b/tools/thermal/tmon/pid.c
index c54edb4f630c..cbacd3b438b2 100644
--- a/tools/thermal/tmon/pid.c
+++ b/tools/thermal/tmon/pid.c
@@ -54,8 +54,6 @@ static double xk_1, xk_2; /* input temperature x[k-#] */
  */
 int init_thermal_controller(void)
 {
-	int ret = 0;
-
 	/* init pid params */
 	p_param.ts = ticktime;
 	/* TODO: get it from TUI tuning tab */
@@ -65,7 +63,7 @@ int init_thermal_controller(void)
 
 	p_param.t_target = target_temp_user;
 
-	return ret;
+	return 0;
 }
 
 void controller_reset(void)
-- 
2.30.2