linux-kernel - Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YHXCboJUF1VuZiKz@smile.fi.intel.com>
Date:   Tue, 13 Apr 2021 19:10:22 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Daniel Scally <djrscally@...il.com>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yong Zhi <yong.zhi@...el.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when
 looping over ACPI devices

On Mon, Apr 05, 2021 at 09:37:28PM +0100, Daniel Scally wrote:
> On 04/04/2021 19:14, Andy Shevchenko wrote:
> > When we continue, due to device is disabled, loop we have to drop reference count.
> > When we have an array full of devices we have to also drop the reference count.
> > Note, in this case the cio2_bridge_unregister_sensors() is called by the caller.
> >
> > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> > Cc: Daniel Scally <djrscally@...il.com>
> > Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Ah; thanks for catching those, I'm annoyed to have missed the
> acpi_dev_put() calls in particular
> 
> Reviewed-by: Daniel Scally <djrscally@...il.com>

Sakari, Mauro, can this be applied as v5.12 material, please?

-- 
With Best Regards,
Andy Shevchenko