linux-kernel - Re: [PATCH 1/1] seccomp: Always "goto wait" if the list is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACaBj2ZieT2vH3_ywSkzzWXjJuSdBr1ytXdazTJ9-8mmA7xNvg@mail.gmail.com>
Date:   Tue, 13 Apr 2021 20:02:35 +0200
From:   Rodrigo Campos <rodrigo@...volk.io>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Containers <containers@...ts.linux-foundation.org>,
        Sargun Dhillon <sargun@...gun.me>,
        Mauricio Vásquez Bernal <mauricio@...volk.io>,
        Alban Crequy <alban@...volk.io>, stable@...r.kernel.org
Subject: Re: [PATCH 1/1] seccomp: Always "goto wait" if the list is empty

On Tue, Apr 13, 2021 at 7:54 PM Christian Brauner
<christian.brauner@...ntu.com> wrote:
> > Fixes: 7cf97b1254550
> > Cc: stable@...r.kernel.org # 5.9+
> > Signed-off-by: Rodrigo Campos <rodrigo@...volk.io>
> > ---
>
> So the agent will see the return value from
> wait_for_completion_interruptible() and know that the addfd wasn't
> successful and the target will notice that no addfd request has actually
> been added and essentially try again. Seems like a decent fix and can be

Yes, exactly!

> backported cleanly. I assume seccomp testsuite passes.

Yes, seccomp selftests (tools/testing/selftests/seccomp/seccomp_bpf) passes fine

> Acked-by: Christian Brauner <christian.brauner@...ntu.com>

Thanks!