linux-kernel - Re: [PATCH] Bluetooth: btusb: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E4C40E0D-4D06-4E3C-BEA3-079FACEE1A06@holtmann.org>
Date:   Tue, 13 Apr 2021 20:35:02 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Muhammad Usama Anjum <musamaanjum@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "mark-yw.chen" <mark-yw.chen@...iatek.com>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, dan.carpenter@...cle.com,
        colin.king@...onical.com
Subject: Re: [PATCH] Bluetooth: btusb: fix memory leak

Hi Muhammad,

> If btusb_mtk_submit_wmt_recv_urb returns error, wc should be freed and
> then error should be returned to prevent memory leak.
> 
> Addresses-Coverity: ("Prevent memory leak")
> Fixes: 4cbb375e997d ("Bluetooth: btusb: Fixed too many in-token issue for Mediatek Chip.")
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@...il.com>
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel