linux-kernel - Re: [PATCH 2/4] dt-bindings: Add bindings for aspeed pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <106D8276-51DF-4319-BDB4-68D1C0B2971A@aspeedtech.com>
Date:   Tue, 13 Apr 2021 07:27:51 +0000
From:   Billy Tsai <billy_tsai@...eedtech.com>
To:     Rob Herring <robh@...nel.org>
CC:     "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "andrew@...id.au" <andrew@...id.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "joel@....id.au" <joel@....id.au>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        BMC-SW <BMC-SW@...eedtech.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [PATCH 2/4] dt-bindings: Add bindings for aspeed pwm

Hi Rob,

Best Regards,
Billy Tsai

On 2021/4/12, 9:20 PM,Rob Herringwrote:

    On Mon, 12 Apr 2021 17:54:55 +0800, Billy Tsai wrote:
    >> This patch adds device bindings for aspeed pwm device which should be
    >> the sub-node of aspeed,ast2600-pwm-tach.
    >> 
    >> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
    >> ---
    >>  .../bindings/pwm/aspeed,ast2600-pwm.yaml      | 47 +++++++++++++++++++
    >>  1 file changed, 47 insertions(+)
    >>  create mode 100644 Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
    >> 

    > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    > on your patch (DT_CHECKER_FLAGS is new in v5.13):

    > yamllint warnings/errors:

    > dtschema/dtc warnings/errors:
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml: Additional properties are not allowed ('pwm-cells' was unexpected)
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml: Additional properties are not allowed ('pwm-cells' was unexpected)
    > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml: ignoring, error in schema: 
    > warning: no schema found in file: ./Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
    > Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.example.dt.yaml:0:0: /example-0/pwm_tach@...10000: failed to match any schema with compatible: ['aspeed,ast2600-pwm-tach', 'simple-mfd', 'syscon']
    > Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.example.dt.yaml:0:0: /example-0/pwm_tach@...10000/pwm@0: failed to match any schema with compatible: ['aspeed,ast2600-pwm']

The yaml file have dependencies with the first patch in these series. I will squash them.

    > See https://patchwork.ozlabs.org/patch/1465116

    > This check can fail if there are any dependencies. The base for a patch
    > series is generally the most recent rc1.

    > If you already ran 'make dt_binding_check' and didn't see the above
    > error(s), then make sure 'yamllint' is installed and dt-schema is up to
    > date:

    > pip3 install dtschema --upgrade

    > Please check and re-submit.