linux-kernel - Re: [PATCH -next] sched/topology: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YHVjOeSGT3xe2smj@google.com>
Date:   Tue, 13 Apr 2021 09:24:09 +0000
From:   Quentin Perret <qperret@...gle.com>
To:     Peng Wu <wupeng58@...wei.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] sched/topology: Make some symbols static

On Thursday 08 Apr 2021 at 21:12:17 (+0800), Peng Wu wrote:
> The sparse tool complains as follows:
> 
> kernel/sched/topology.c:211:1: warning:
>  symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning:
>  symbol 'sched_energy_update' was not declared. Should it be static?
> 
> This symbol is not used outside of topology.c, so this
> commit marks it static.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Peng Wu <wupeng58@...wei.com>
> ---
>  kernel/sched/topology.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index d1aec244c027..25c3f88d43cd 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
>  #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
>  DEFINE_STATIC_KEY_FALSE(sched_energy_present);
>  unsigned int sysctl_sched_energy_aware = 1;
> -DEFINE_MUTEX(sched_energy_mutex);
> -bool sched_energy_update;
> +static DEFINE_MUTEX(sched_energy_mutex);
> +static bool sched_energy_update;
>  
>  void rebuild_sched_domains_energy(void)
>  {
>

FWIW, that has been reported some time ago:

https://lore.kernel.org/lkml/1606218731-3999-1-git-send-email-zou_wei@huawei.com/
https://lore.kernel.org/lkml/1606271447-74720-1-git-send-email-zou_wei@huawei.com/

But otherwise, this looks OK to me.

Thanks,
Quentin