linux-kernel - Re: [PATCH 03/12] usb: dwc2: Allow entering clock gating from USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4aace947-826f-7e45-f2f8-2bbfaf9f1420@gmail.com>
Date:   Tue, 13 Apr 2021 12:25:20 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Artur Petrosyan <Arthur.Petrosyan@...opsys.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     John Youn <John.Youn@...opsys.com>
Subject: Re: [PATCH 03/12] usb: dwc2: Allow entering clock gating from
 USB_SUSPEND interrupt

On 13.04.2021 10:16, Artur Petrosyan wrote:

> If core doesn't support hibernation or partial power
> down power saving options, power can still be saved
> using clock gating on all the clocks.
> 
> - Added entering clock gating state from USB_SUSPEND
>    interrupt.
> 
> Signed-off-by: Artur Petrosyan <Arthur.Petrosyan@...opsys.com>
> Acked-by: Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
> ---
>   drivers/usb/dwc2/core_intr.c | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
> index 8c0152b514be..ab7fe303c0f9 100644
> --- a/drivers/usb/dwc2/core_intr.c
> +++ b/drivers/usb/dwc2/core_intr.c
> @@ -529,14 +529,18 @@ static void dwc2_handle_usb_suspend_intr(struct dwc2_hsotg *hsotg)
>   				/* Ask phy to be suspended */
>   				if (!IS_ERR_OR_NULL(hsotg->uphy))
>   					usb_phy_set_suspend(hsotg->uphy, true);
> -			}
> -
> -			if (hsotg->hw_params.hibernation) {
> +			} else if (hsotg->hw_params.hibernation) {
>   				ret = dwc2_enter_hibernation(hsotg, 0);
>   				if (ret && ret != -ENOTSUPP)
>   					dev_err(hsotg->dev,
>   						"%s: enter hibernation failed\n",
>   						__func__);
> +			} else {
> +				/*
> +				 * If not hibernation nor partial power down are supported,

    s/not/neither/?

[...]

MBR, Sergei