[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210413095257.GA21802@lpieralisi>
Date: Tue, 13 Apr 2021 10:53:05 +0100
From: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To: Pali Rohár <pali@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Jianjun Wang <jianjun.wang@...iatek.com>,
Rob Herring <robh+dt@...nel.org>,
Marc Zyngier <maz@...nel.org>,
Ryder Lee <ryder.lee@...iatek.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Matthias Brugger <matthias.bgg@...il.com>,
linux-pci@...r.kernel.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, youlin.pei@...iatek.com,
chuanjia.liu@...iatek.com, qizhong.cheng@...iatek.com,
sin_jieyang@...iatek.com, drinkcat@...omium.org,
Rex-BC.Chen@...iatek.com, anson.chuang@...iatek.com,
Krzysztof Wilczyski <kw@...ux.com>
Subject: Re: [v9,2/7] PCI: Export pci_pio_to_address() for module use
On Wed, Mar 24, 2021 at 10:09:42AM +0100, Pali Rohár wrote:
> On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote:
> > This interface will be used by PCI host drivers for PIO translation,
> > export it to support compiling those drivers as kernel modules.
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@...iatek.com>
> > ---
> > drivers/pci/pci.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 16a17215f633..12bba221c9f2 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio)
> >
> > return address;
> > }
> > +EXPORT_SYMBOL(pci_pio_to_address);
>
> Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0
> header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe
> other people would know what is correct?
I think this should be EXPORT_SYMBOL_GPL(), I can make this change
but this requires Bjorn's ACK to go upstream (Bjorn, it is my fault,
it was assigned to me on patchwork, now updated, please have a look).
Thanks,
Lorenzo
> >
> > unsigned long __weak pci_address_to_pio(phys_addr_t address)
> > {
> > --
> > 2.25.1
> >
Powered by blists - more mailing lists