linux-kernel - Re: [PATCH] media: solo6x10: remove useless function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210413100228.GC27272@pirotess>
Date:   Tue, 13 Apr 2021 12:02:28 +0200
From:   Ismael Luceno <ismael@...ev.co.uk>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     maintainers@...echerrydvr.com, anton@...p.bluecherry.net,
        andrey_utkin@...tmail.com, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: solo6x10: remove useless function

NACK; before removing any of these functions the fields should be
documented somewhere else, so that no information is lost.

On 13/Apr/2021 15:23, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c:394:19: warning: unused
> function 'vop_interlaced' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> index 0abcad4..8c4fae7 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> @@ -391,11 +391,6 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip,
>  }
>  
>  /* Extract values from VOP header - VE_STATUSxx */
> -static inline int vop_interlaced(const vop_header *vh)
> -{
> -	return (__le32_to_cpu((*vh)[0]) >> 30) & 1;
> -}
> -
>  static inline u8 vop_channel(const vop_header *vh)
>  {
>  	return (__le32_to_cpu((*vh)[0]) >> 24) & 0x1F;
> -- 
> 1.8.3.1
> 

-- 
Ismael Luceno
http://iodev.co.uk/