linux-kernel - Re: [PATCH v2 1/1] devres: Enable trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YHWNyXdpHBsllTSx@smile.fi.intel.com>
Date:   Tue, 13 Apr 2021 15:25:45 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v2 1/1] devres: Enable trace events

On Tue, Apr 13, 2021 at 03:00:52PM +0300, Heikki Krogerus wrote:
> On Tue, Apr 13, 2021 at 02:38:01PM +0300, Andy Shevchenko wrote:
> > In some cases the printf() mechanism is too heavy and can't be used.
> > For example, when debugging a race condition involving devres API.
> > When CONFIG_DEBUG_DEVRES is enabled I can't reproduce an issue, and
> > otherwise it's quite visible with a useful information being collected.
> > 
> > Enable trace events for devres part of the driver core.

...

> >  struct devres_node {
> >  	struct list_head		entry;
> >  	dr_release_t			release;
> > -#ifdef CONFIG_DEBUG_DEVRES
> >  	const char			*name;
> >  	size_t				size;
> > -#endif
> 
> Those ifdefs are still required.

Oh, yes, otherwise we end up with not filled name and size (as per header
file). I'll rework in order to fill name and size always and get rid of
ifdeffery in the header file.

Thanks!

> >  };

-- 
With Best Regards,
Andy Shevchenko