linux-kernel - Re: [PATCH] watchdog: it87_wdt: remove useless function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Apr 2021 08:01:08 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: it87_wdt: remove useless function

On 4/13/21 2:34 AM, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> drivers/watchdog/it87_wdt.c:155:20: warning: unused function
> 'superio_outw' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/it87_wdt.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index 2b48318..bb11229 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -152,14 +152,6 @@ static inline int superio_inw(int reg)
>  	return val;
>  }
>  
> -static inline void superio_outw(int val, int reg)
> -{
> -	outb(reg++, REG);
> -	outb(val >> 8, VAL);
> -	outb(reg, REG);
> -	outb(val, VAL);
> -}
> -
>  /* Internal function, should be called after superio_select(GPIO) */
>  static void _wdt_update_timeout(unsigned int t)
>  {
>