linux-kernel - Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03549d0e-04d9-6d37-93e3-c09b29ce53aa@xs4all.nl>
Date:   Tue, 13 Apr 2021 17:06:10 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Aline Santana Cordeiro <alinesantanacordeiro@...il.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
> Remove unused macro functions "to_iss_device()", "to_device()",
> and "v4l2_dev_to_iss_device(dev)".

'git grep to_iss_device drivers/staging/omap4iss' gives me lots of hits!
Same for to_device. Only v4l2_dev_to_iss_device appears to be unused.

Regards,

	Hans

> 
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@...il.com>
> ---
>  drivers/staging/media/omap4iss/iss.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss.h b/drivers/staging/media/omap4iss/iss.h
> index b88f952..a354d5f 100644
> --- a/drivers/staging/media/omap4iss/iss.h
> +++ b/drivers/staging/media/omap4iss/iss.h
> @@ -29,11 +29,6 @@
>  
>  struct regmap;
>  
> -#define to_iss_device(ptr_module)				\
> -	container_of(ptr_module, struct iss_device, ptr_module)
> -#define to_device(ptr_module)						\
> -	(to_iss_device(ptr_module)->dev)
> -
>  enum iss_mem_resources {
>  	OMAP4_ISS_MEM_TOP,
>  	OMAP4_ISS_MEM_CSI2_A_REGS1,
> @@ -119,9 +114,6 @@ struct iss_device {
>  	unsigned int isp_subclk_resources;
>  };
>  
> -#define v4l2_dev_to_iss_device(dev) \
> -	container_of(dev, struct iss_device, v4l2_dev)
> -
>  int omap4iss_get_external_info(struct iss_pipeline *pipe,
>  			       struct media_link *link);
>  
>