linux-kernel - Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 15:55:42 -0300
From:   ascordeiro <alinesantanacordeiro@...il.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH] staging: media: atomisp: pci: Format multi-line
 comments according to coding-style in file atomisp_cmd.c

Em qua, 2021-04-14 às 21:33 +0300, Sakari Ailus escreveu:
> Hi Aline,
> 
> Thanks for the patch.
> 
> On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro
> wrote:
> > Format multi-line comments according to the coding-style.
> > Issue detected by checkpatch.pl.
> > 
> > Signed-off-by: Aline Santana Cordeiro <
> > alinesantanacordeiro@...il.com>
> > ---
> >  drivers/staging/media/atomisp/pci/atomisp_cmd.c | 109
> > ++++++++++++++----------
> >  1 file changed, 65 insertions(+), 44 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > index 592ea99..6113785 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > @@ -67,7 +67,8 @@
> >   * At 15fps this means 133ms. We set the timeout a bit longer.
> >   * Each flash driver is supposed to set its own timeout, but
> >   * just in case someone else changed the timeout, we set it
> > - * here to make sure we don't damage the flash hardware. */
> > + * here to make sure we don't damage the flash hardware.
> > + */
> >  #define FLASH_TIMEOUT 800 /* ms */
> >  
> >  union host {
> > @@ -562,7 +563,8 @@ irqreturn_t atomisp_isr(int irq, void *dev)
> >                          * and driver needs to keep old
> > sequence_temp value.
> >                          * NOTE: There is assumption here that ISP
> > will not
> >                          * start processing next frame from sensor
> > before old
> > -                        * one is completely done. */
> > +                        * one is completely done.
> > +                        */
> >                         if (atomic_read(&asd->sequence) ==
> > atomic_read(
> >                                 &asd->sequence_temp))
> >                                 atomic_set(&asd->sequence_temp,
> > @@ -1247,7 +1249,8 @@ void atomisp_buf_done(struct
> > atomisp_sub_device *asd, int error,
> >  
> >         if (IS_ISP2401) {
> >                 /* If there are no buffers queued then
> 
> This should begin with:
> 
>                 /*
>                  *
> 
> And the same for the rest. Apart from this the patch seems fine.
> 
Hi Sakari,

I'm going to send a v2 correcting all the multi-line comments that are
not beginning like this.

Besides, there are single line comments with different styles, a few
like this:

case 1:				/* comment */

and the other like this:
				/*
case2:				 * comment
 				 */

Should I standardize these ones to the first case?

Thank you for yout attention,
Aline