linux-kernel - Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2104141203480.482712@rhweight-WRK1>
Date:   Wed, 14 Apr 2021 12:09:50 -0700 (PDT)
From:   matthew.gerlach@...ux.intel.com
To:     Mark Brown <broonie@...nel.org>
cc:     hao.wu@...el.com, trix@...hat.com, mdf@...nel.org,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        yilun.xu@...el.com, jdelvare@...e.com, linux@...ck-us.net,
        lee.jones@...aro.org, linux-hwmon@...r.kernel.org,
        russell.h.weight@...el.com, linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master



On Wed, 14 Apr 2021, Mark Brown wrote:

> On Tue, Apr 13, 2021 at 03:58:34PM -0700, matthew.gerlach@...ux.intel.com wrote:
>
>> +++ b/drivers/spi/spi-altera-dfl.c
>> @@ -0,0 +1,222 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * DFL bus driver for Altera SPI Master
>> + *
>
> Please make the entire comment a C++ one so things look more
> intentional.

Ok, I'll change it in the next revision.

>
>> +	memset(&pdevinfo, 0, sizeof(pdevinfo));
>> +
>> +	pdevinfo.name = "subdev_spi_altera";
>> +	pdevinfo.id = PLATFORM_DEVID_AUTO;
>> +	pdevinfo.parent = dev;
>> +	pdevinfo.data = &pdata;
>> +	pdevinfo.size_data = sizeof(pdata);
>> +
>> +	return platform_device_register_full(&pdevinfo);
>
> Don't create a platform device here, extend the spi-altera driver to
> register with both DFL and platform buses.
>

Are you suggesting something like the SPI driver for the Designware 
controller where there is spi-dw-core.c and bus specific code like 
spi-dw-pci.c and spi-dw-mmioc.c?

Thanks for the review.

Matthew