linux-kernel - Re: [PATCH v1 1/3] dt-bindings: arm: imx: Add i.mx6q DaSheng COM-9XX SBC board dts support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL9mu0+U2PN2HsQdw5mYGap+bH_YN55RyT-tw65EfH3zKxwScQ@mail.gmail.com>
Date:   Wed, 14 Apr 2021 14:40:26 +0800
From:   dillon min <dillon.minfei@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        linux@...pel-privat.de, s.riedmueller@...tec.de,
        matthias.schiffer@...tq-group.com, leoyang.li@....com,
        arnd@...db.de, olof@...om.net,
        Sascha Hauer <s.hauer@...gutronix.de>, kernel@...gutronix.de,
        festevam@...il.com, prabhakar.csengg@...il.com, mchehab@...nel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-imx@....com, linux-media@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: imx: Add i.mx6q DaSheng COM-9XX
 SBC board dts support

On Wed, Apr 14, 2021 at 2:22 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> On 14/04/2021 08:13, dillon.minfei@...il.com wrote:
> > From: dillon min <dillon.minfei@...il.com>
> >
> > The DaSheng Com-9xx is and ARM based signle board computer (SBC)
> > featuring:
> > - i.MX6Q
> > - 2GiB LPDDR3 DRAM
> > - 8GiB eMMC 5.0 FLASH
> > - 4MiB SPI Flash
> > - USB 2.0 Host/Device
> > - Multiple multi-protocol RS232/RS485 Serial ports
> > - microSD socket
> > - 5V DC power input
> > - HDMI1.4a,1080p@60
> > - RGMIIx1 Gigabit Ethernet
> > - CSI0x1, connect with ov2659
> >
> > Signed-off-by: dillon min <dillon.minfei@...il.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 297c87f45db8..24bdfbd4853f 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -206,6 +206,7 @@ properties:
> >                - fsl,imx6q-sabreauto
> >                - fsl,imx6q-sabrelite
> >                - fsl,imx6q-sabresd
> > +              - ds,imx6q-sbc              # Da Sheng COM-9XX Modules
> >                - karo,imx6q-tx6q           # Ka-Ro electronics TX6Q Modules
> >                - kiebackpeter,imx6q-tpc    # K+P i.MX6 Quad TPC Board
> >                - kontron,imx6q-samx6i      # Kontron i.MX6 Dual/Quad SMARC Module
> >
>
> You miss change in vendor prefixes. Didn't checkpatch complain about it?
> Did you run checkpatch?

Yes. was checked with checkpatch, since it's a warning, i forget to
fix it.thanks.
Will add vendor prefixes to vendor-prefixes.yaml in v2

Thanks.
Dillon,

> Best regards,
> Best regards,
> Krzysztof