linux-kernel - [PATCH] power: supply: cpcap-battery: fix invalid usage of list cursor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 14:47:24 +0800
From:   zhuguangqing83@...il.com
To:     Sebastian Reichel <sre@...nel.org>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guangqing Zhu <zhuguangqing83@...il.com>
Subject: [PATCH] power: supply: cpcap-battery: fix invalid usage of list cursor

From: Guangqing Zhu <zhuguangqing83@...il.com>

Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
When list is empty or if the list is completely traversed (without breaking
from the loop on one of the entries) then the list cursor does not point
to a valid entry and therefore should not be used. "if (!d)" will never
happen, maybe we should use "if (&d->node == &ddata->irq_list)".

Fixes: 874b2adbed125 ("power: supply: cpcap-battery: Add a battery driver")
Signed-off-by: Guangqing Zhu <zhuguangqing83@...il.com>
---
 drivers/power/supply/cpcap-battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 6d5bcdb9f45d..8169dc71a786 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
 			break;
 	}
 
-	if (!d)
+	if (&d->node == &ddata->irq_list)
 		return IRQ_NONE;
 
 	latest = cpcap_battery_latest(ddata);
-- 
2.17.1