[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210414075649.GC2180@ninjato>
Date: Wed, 14 Apr 2021 09:56:49 +0200
From: Wolfram Sang <wsa@...nel.org>
To: Ye Weihua <yeweihua4@...wei.com>
Cc: aisheng.dong@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, yangjihong1@...wei.com,
zhangjinhao2@...wei.com
Subject: Re: [PATCH -next] i2c: imx-lpi2c: fix PM reference leak in
lpi2c_imx_master_enable()
On Thu, Apr 08, 2021 at 07:19:30PM +0800, Ye Weihua wrote:
> The PM reference count is not expected to be incremented on return in
> ipi2c_imx_master_enable().
>
> However, pm_runtime_get_sync() will increment the PM reference count
> even on failure. forgetting to put the reference again will result in
> a leak.
>
> Replace it with pm_runtime_resume_and_get() to keep the usage counter
> balanced.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ye Weihua <yeweihua4@...wei.com>
Thanks, yet I applied this series now:
http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists