linux-kernel - Re: [PATCH -next] i2c: imx: Fix PM reference leak in i2c_imx_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210414080412.GI2180@ninjato>
Date:   Wed, 14 Apr 2021 10:04:12 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Ye Weihua <yeweihua4@...wei.com>
Cc:     linux@...pel-privat.de, kernel@...gutronix.de, shawnguo@...nel.org,
        s.hauer@...gutronix.de, festevam@...il.com, linux-imx@....com,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, yangjihong1@...wei.com,
        zhangjinhao2@...wei.com
Subject: Re: [PATCH -next] i2c: imx: Fix PM reference leak in
 i2c_imx_reg_slave()

On Thu, Apr 08, 2021 at 07:06:38PM +0800, Ye Weihua wrote:
> The PM reference count is not expected to be incremented on return in
> these functions.
> 
> However, pm_runtime_get_sync() will increment the PM reference count
> even on failure. forgetting to put the reference again will result in
> a leak.
> 
> Replace it with pm_runtime_resume_and_get() to keep the usage counter
> balanced.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ye Weihua <yeweihua4@...wei.com>

After rebasing, only one hunk was left:

> @@ -801,7 +801,7 @@ static int i2c_imx_reg_slave(struct i2c_client *client)
>  	i2c_imx->last_slave_event = I2C_SLAVE_STOP;
>  
>  	/* Resume */
> -	ret = pm_runtime_get_sync(i2c_imx->adapter.dev.parent);
> +	ret = pm_runtime_resume_and_get(i2c_imx->adapter.dev.parent);
>  	if (ret < 0) {
>  		dev_err(&i2c_imx->adapter.dev, "failed to resume i2c controller");
>  		return ret;

I applied this to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)