linux-kernel - Re: [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d03e8b4ce25fe9e3b5e5597d83802eea83e7caa2.camel@perches.com>
Date:   Wed, 14 Apr 2021 01:32:27 -0700
From:   Joe Perches <joe@...ches.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on
 DBG_871X removal sites

On Tue, 2021-04-13 at 17:52 +0300, Dan Carpenter wrote:
> On Wed, Apr 07, 2021 at 03:49:36PM +0200, Fabio Aiuto wrote:
> > @@ -2586,11 +2583,9 @@ static int rtw_dbg_port(struct net_device *dev,
> >  
> > 
> >  								plist = get_next(plist);
> >  
> > 
> > -								if (extra_arg == psta->aid) {
> > -									for (j = 0; j < 16; j++) {
> > +								if (extra_arg == psta->aid)
> > +									for (j = 0; j < 16; j++)
> >  										preorder_ctrl = &psta->recvreorder_ctrl[j];
> > -									}
> > -								}
> 
> I think Greg already applied this so no stress (don't bother fixing),
> but you removed a bit too much on this one.  Multi-line indents normally
> get curly braces for readability.  In other words:
> 
> 				if (extra_arg == psta->aid) {
> 					for (j = 0; j < 16; j++)
> 						preorder_ctrl = &psta->recvreorder_ctrl[j];
> 				}
> 
> regards,
> dan carpenter
>