linux-kernel - Re: [PATCH] esp6: Simplify the calculation of variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 12:11:28 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <yoshfuji@...ux-ipv6.org>, <dsahern@...nel.org>, <kuba@...nel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] esp6: Simplify the calculation of variables

On Tue, Apr 13, 2021 at 05:57:15PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./net/ipv6/esp6_offload.c:321:32-34: WARNING !A || A && B is equivalent
> to !A || B.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  net/ipv6/esp6_offload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/esp6_offload.c b/net/ipv6/esp6_offload.c
> index 4af56af..40ed4fc 100644
> --- a/net/ipv6/esp6_offload.c
> +++ b/net/ipv6/esp6_offload.c
> @@ -318,7 +318,7 @@ static int esp6_xmit(struct xfrm_state *x, struct sk_buff *skb,  netdev_features
>  	esp.plen = esp.clen - skb->len - esp.tfclen;
>  	esp.tailen = esp.tfclen + esp.plen + alen;
>  
> -	if (!hw_offload || (hw_offload && !skb_is_gso(skb))) {
> +	if (!hw_offload || !skb_is_gso(skb)) {
>  		esp.nfrags = esp6_output_head(x, skb, &esp);
>  		if (esp.nfrags < 0)
>  			return esp.nfrags;

That one is already in ipsec-next:

Commit f076835a8bf2aa6ea48f718e4506587c815ab99f
Author: Junlin Yang <yangjunlin@...ong.com>
Date:   Thu Mar 11 10:07:56 2021 +0800

    esp6: remove a duplicative condition

    Fixes coccicheck warnings:
    ./net/ipv6/esp6_offload.c:319:32-34:
    WARNING !A || A && B is equivalent to !A || B

    Signed-off-by: Junlin Yang <yangjunlin@...ong.com>
    Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>