linux-kernel - Re: [PATCH] cxl/mem: Add media provisioning required commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Apr 2021 13:36:58 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Ben Widawsky <ben.widawsky@...el.com>
CC:     <linux-cxl@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <ira.weiny@...el.com>,
        <vishal.l.verma@...el.com>, <alison.schofield@...el.com>,
        <dan.j.williams@...el.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/mem: Add media provisioning required commands

On Tue, 13 Apr 2021 07:09:07 -0700
Ben Widawsky <ben.widawsky@...el.com> wrote:

> Some of the commands have already been defined for the support of RAW
> commands (to be blocked). Unlike their usage in the RAW interface, when
> used through the supported interface, they will be coordinated and
> marshalled along with other commands being issued by userspace and the
> driver itself. That coordination will be added later.
> 
> The list of commands was determined based on the learnings from
> libnvdimm and this list is provided directly from Dan.
> 
> Recommended-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Ben Widawsky <ben.widawsky@...el.com>

Checked all the numbers (not much else in this one ;)

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

You could give more info on why this particular list, but to my
mind it's all fairly obvious so perhaps not worth bothering.

> ---
>  drivers/cxl/mem.c            | 19 +++++++++++++++++++
>  include/uapi/linux/cxl_mem.h | 12 ++++++++++++
>  2 files changed, 31 insertions(+)
> 
> diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c
> index e915e3743b76..e3306aa560cf 100644
> --- a/drivers/cxl/mem.c
> +++ b/drivers/cxl/mem.c
> @@ -50,7 +50,14 @@ enum opcode {
>  	CXL_MBOX_OP_GET_LSA		= 0x4102,
>  	CXL_MBOX_OP_SET_LSA		= 0x4103,
>  	CXL_MBOX_OP_GET_HEALTH_INFO	= 0x4200,
> +	CXL_MBOX_OP_GET_ALERT_CONFIG	= 0x4201,
> +	CXL_MBOX_OP_SET_ALERT_CONFIG	= 0x4202,
> +	CXL_MBOX_OP_GET_SHUTDOWN_STATE	= 0x4203,
>  	CXL_MBOX_OP_SET_SHUTDOWN_STATE	= 0x4204,
> +	CXL_MBOX_OP_GET_POISON		= 0x4300,
> +	CXL_MBOX_OP_INJECT_POISON	= 0x4301,
> +	CXL_MBOX_OP_CLEAR_POISON	= 0x4302,
> +	CXL_MBOX_OP_GET_SCAN_MEDIA_CAPS	= 0x4303,
>  	CXL_MBOX_OP_SCAN_MEDIA		= 0x4304,
>  	CXL_MBOX_OP_GET_SCAN_MEDIA	= 0x4305,
>  	CXL_MBOX_OP_MAX			= 0x10000
> @@ -158,6 +165,18 @@ static struct cxl_mem_command mem_commands[CXL_MEM_COMMAND_ID_MAX] = {
>  	CXL_CMD(GET_LSA, 0x8, ~0, 0),
>  	CXL_CMD(GET_HEALTH_INFO, 0, 0x12, 0),
>  	CXL_CMD(GET_LOG, 0x18, ~0, CXL_CMD_FLAG_FORCE_ENABLE),
> +	CXL_CMD(SET_PARTITION_INFO, 0x0a, 0, 0),
> +	CXL_CMD(SET_LSA, ~0, 0, 0),
> +	CXL_CMD(GET_ALERT_CONFIG, 0, 0x10, 0),
> +	CXL_CMD(SET_ALERT_CONFIG, 0xc, 0, 0),
> +	CXL_CMD(GET_SHUTDOWN_STATE, 0, 0x1, 0),
> +	CXL_CMD(SET_SHUTDOWN_STATE, 0x1, 0, 0),
> +	CXL_CMD(GET_POISON, 0x10, ~0, 0),
> +	CXL_CMD(INJECT_POISON, 0x8, 0, 0),
> +	CXL_CMD(CLEAR_POISON, 0x48, 0, 0),
> +	CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0),
> +	CXL_CMD(SCAN_MEDIA, 0x11, 0, 0),
> +	CXL_CMD(GET_SCAN_MEDIA, 0, ~0, 0),
>  };
>  
>  /*
> diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> index 3155382dfc9b..f6e8a005b113 100644
> --- a/include/uapi/linux/cxl_mem.h
> +++ b/include/uapi/linux/cxl_mem.h
> @@ -29,6 +29,18 @@
>  	___C(GET_LSA, "Get Label Storage Area"),                          \
>  	___C(GET_HEALTH_INFO, "Get Health Info"),                         \
>  	___C(GET_LOG, "Get Log"),                                         \
> +	___C(SET_PARTITION_INFO, "Set Partition Information"),            \
> +	___C(SET_LSA, "Set Label Storage Area"),                          \
> +	___C(GET_ALERT_CONFIG, "Get Alert Configuration"),                \
> +	___C(SET_ALERT_CONFIG, "Set Alert Configuration"),                \
> +	___C(GET_SHUTDOWN_STATE, "Get Shutdown State"),                   \
> +	___C(SET_SHUTDOWN_STATE, "Set Shutdown State"),                   \
> +	___C(GET_POISON, "Get Poison List"),                              \
> +	___C(INJECT_POISON, "Inject Poison"),                             \
> +	___C(CLEAR_POISON, "Clear Poison"),                               \
> +	___C(GET_SCAN_MEDIA_CAPS, "Get Scan Media Capabilities"),         \
> +	___C(SCAN_MEDIA, "Scan Media"),                                   \
> +	___C(GET_SCAN_MEDIA, "Get Scan Media Results"),                   \
>  	___C(MAX, "invalid / last command")
>  
>  #define ___C(a, b) CXL_MEM_COMMAND_ID_##a