linux-kernel - Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Apr 2021 21:33:12 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Julian Braha <julianbraha@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on
 GPIOLIB

On Thu 08 Apr 03:03 CDT 2021, Linus Walleij wrote:

> On Mon, Mar 29, 2021 at 6:41 PM Julian Braha <julianbraha@...il.com> wrote:
> >
> > On Tuesday, March 2, 2021 9:46:04 AM EDT you wrote:
> > > On Thu, Feb 25, 2021 at 9:33 AM Julian Braha <julianbraha@...il.com> wrote:
> > >
> > > > When PINCTRL_MSM is enabled, and GPIOLIB is disabled,
> > > > Kbuild gives the following warning:
> > > >
> > > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
> > > >   Depends on [n]: GPIOLIB [=n]
> > > >   Selected by [y]:
> > > >   - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y])
> > > >
> > > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP,
> > > > without selecting or depending on GPIOLIB, despite
> > > > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM
> > > > select GPIOLIB will cause a recursive dependency error.
> > > >
> > > > Signed-off-by: Julian Braha <julianbraha@...il.com>
> > >
> > > Does it work to just:
> > >
> > > select GPIOLIB
> > >
> > > instead?
> > >
> > > The driver needs the library so...
> > >
> > > Yours,
> > > Linus Walleij
> > >
> >
> > Hi Linus,
> >
> > Looks like I confused this patch with another one when
> > I responded last time. This config option cannot select
> > GPIOLIB, because it will cause a recursive dependency
> > error.
> >
> > Any other ideas?
> 
> No we can apply the patch as-is but let Bjorn have  a look at it first,
> I noticed he is not on the To: line of the original patch.
> 
> You may need to resend with Bjorn Andersson in the recipients.
> 

I don't see a resend of this, perhaps I'm just not good at searching
today...I dug up the patch on lore instead.

GPIOLIB is user selectable, so it makes sense to depend on it, rather
than use select. And it seems like our current defconfigs have GPIOLIB
enabled already (directly or indirectly).

So...

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn