linux-kernel - Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210414141816.GD4535@sirena.org.uk>
Date:   Wed, 14 Apr 2021 15:18:16 +0100
From:   Mark Brown <broonie@...nel.org>
To:     matthew.gerlach@...ux.intel.com
Cc:     hao.wu@...el.com, trix@...hat.com, mdf@...nel.org,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        yilun.xu@...el.com, jdelvare@...e.com, linux@...ck-us.net,
        lee.jones@...aro.org, linux-hwmon@...r.kernel.org,
        russell.h.weight@...el.com, linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 1/2] spi: Add DFL bus driver for Altera SPI Master

On Tue, Apr 13, 2021 at 03:58:34PM -0700, matthew.gerlach@...ux.intel.com wrote:

> +++ b/drivers/spi/spi-altera-dfl.c
> @@ -0,0 +1,222 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * DFL bus driver for Altera SPI Master
> + *

Please make the entire comment a C++ one so things look more
intentional.

> +	memset(&pdevinfo, 0, sizeof(pdevinfo));
> +
> +	pdevinfo.name = "subdev_spi_altera";
> +	pdevinfo.id = PLATFORM_DEVID_AUTO;
> +	pdevinfo.parent = dev;
> +	pdevinfo.data = &pdata;
> +	pdevinfo.size_data = sizeof(pdata);
> +
> +	return platform_device_register_full(&pdevinfo);

Don't create a platform device here, extend the spi-altera driver to
register with both DFL and platform buses.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)