linux-kernel - Re: [PATCH 1/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210414143011.GV6021@kadam>
Date:   Wed, 14 Apr 2021 17:30:11 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aline Santana Cordeiro <alinesantanacordeiro@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH 1/2] staging: media: atomisp: pci: Correct identation in
 block of conditional statements in file atomisp_v4l2.c

On Wed, Apr 14, 2021 at 11:06:02AM -0300, Aline Santana Cordeiro wrote:
> Correct identation in block of conditional statements.
> The function "v4l2_device_unregister_subdev()" depends on
> the results of the macro function "list_for_each_entry_safe()".
> 
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@...il.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index 0295e2e..6d853f4 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -1178,7 +1178,7 @@ static void atomisp_unregister_entities(struct atomisp_device *isp)
>  		atomisp_mipi_csi2_unregister_entities(&isp->csi2_port[i]);
>  
>  	list_for_each_entry_safe(sd, next, &isp->v4l2_dev.subdevs, list)
> -	v4l2_device_unregister_subdev(sd);
> +		v4l2_device_unregister_subdev(sd);
>  

It's really more common to use curly braces for list_for_each() one
liners.

	list_for_each_entry_safe(sd, next, &isp->v4l2_dev.subdevs, list) {
		v4l2_device_unregister_subdev(sd);
	}

regards,
dan carpenter