linux-kernel - RE: [PATCH] Drivers: hv: vmbus: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR21MB15933A7D469B6FF2E60368A6D74E9@MWHPR21MB1593.namprd21.prod.outlook.com>
Date:   Wed, 14 Apr 2021 14:48:17 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        KY Srinivasan <kys@...rosoft.com>
CC:     Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Drivers: hv: vmbus: remove unused function

From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> Sent: Tuesday, April 13, 2021 11:21 PM
> 
> Fix the following clang warning:
> 
> drivers/hv/ring_buffer.c:89:1: warning: unused function
> 'hv_set_next_read_location' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/hv/ring_buffer.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index 35833d4..78d4043 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -84,15 +84,6 @@ static void hv_signal_on_write(u32 old_write, struct vmbus_channel
> *channel)
>  	ring_info->ring_buffer->write_index = next_write_location;
>  }
> 
> -/* Set the next read location for the specified ring buffer. */
> -static inline void
> -hv_set_next_read_location(struct hv_ring_buffer_info *ring_info,
> -		    u32 next_read_location)
> -{
> -	ring_info->ring_buffer->read_index = next_read_location;
> -	ring_info->priv_read_index = next_read_location;
> -}
> -
>  /* Get the size of the ring buffer. */
>  static inline u32
>  hv_get_ring_buffersize(const struct hv_ring_buffer_info *ring_info)
> --
> 1.8.3.1

This function became unused as of commit 4226ff69a3df 
("vmbus: simplify hv_ringbuffer_read") on 7/17/2017.

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>