linux-kernel - Re: [PATCHv2] mm/mmap.c: lines in __do_munmap repeat logic of inlined find_vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <459c338e-bd9b-fb27-5d6f-f217b684a9e3@redhat.com>
Date:   Wed, 14 Apr 2021 17:16:11 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Gonzalo Matias Juarez Tello <gmjuareztello@...il.com>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] mm/mmap.c: lines in __do_munmap repeat logic of inlined
 find_vma_intersection

On 08.04.21 05:46, Gonzalo Matias Juarez Tello wrote:
> Some lines in __do_munmap used the same logic as find_vma_intersection
> (which is inlined) instead of directly using that function.
> 
> (Can't believe I made a typo in the first one, compiled this one,
> sorry first patch kinda nervous for some reason)
> 
> Signed-off-by: Gonzalo Matias Juarez Tello <gmjuareztello@...il.com>
> ---
>   mm/mmap.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 3f287599a7a3..1b29f8bf8344 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2823,15 +2823,10 @@ int __do_munmap(struct mm_struct *mm, unsigned long start, size_t len,
>   	arch_unmap(mm, start, end);
>   
>   	/* Find the first overlapping VMA */
> -	vma = find_vma(mm, start);
> +	vma = find_vma_intersection(mm, start, end);
>   	if (!vma)
>   		return 0;
>   	prev = vma->vm_prev;
> -	/* we have  start < vma->vm_end  */
> -
> -	/* if it doesn't overlap, we have nothing.. */
> -	if (vma->vm_start >= end)
> -		return 0;
>   
>   	/*
>   	 * If we need to split any vma, do it now to save pain later.
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb