linux-kernel - Re: [PATCH] block: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <defd9b0d-9ec7-2259-6f67-83bd8cd47973@acm.org>
Date:   Thu, 15 Apr 2021 08:37:11 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: remove unused function

On 4/15/21 1:39 AM, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> block/blk-zoned.c:55:24: warning: unused function 'blk_zone_start'
> [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  block/blk-zoned.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index c0276b42..250cb76 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -52,14 +52,6 @@ const char *blk_zone_cond_str(enum blk_zone_cond zone_cond)
>  }
>  EXPORT_SYMBOL_GPL(blk_zone_cond_str);
>  
> -static inline sector_t blk_zone_start(struct request_queue *q,
> -				      sector_t sector)
> -{
> -	sector_t zone_mask = blk_queue_zone_sectors(q) - 1;
> -
> -	return sector & ~zone_mask;
> -}

A similar patch is already in Jens' for-5.13/block branch. See also
commit 540ad3f3da25 ("blk-zoned: Remove the definition of
blk_zone_start()").

Bart.