[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YHhfCr+7KztYpIkD@google.com>
Date: Thu, 15 Apr 2021 15:43:06 +0000
From: Quentin Perret <qperret@...gle.com>
To: Lukasz Luba <lukasz.luba@....com>
Cc: Vincent Donnefort <vincent.donnefort@....com>,
peterz@...radead.org, rjw@...ysocki.net, viresh.kumar@...aro.org,
vincent.guittot@...aro.org, linux-kernel@...r.kernel.org,
ionela.voinescu@....com, dietmar.eggemann@....com
Subject: Re: [PATCH] PM / EM: Inefficient OPPs detection
On Thursday 15 Apr 2021 at 16:32:31 (+0100), Lukasz Luba wrote:
> Are you sure that the 'policy' can be accessed from compute_energy()?
> It can be from schedutil freq switch path, but I'm not use about our
> feec()..
Right, I was just looking at cpufreq_cpu_get() and we'll have locking
issue in the wake-up path :/ So maybe making feec() aware of policy caps
is for later ...
> For me this cpufreq_driver_resolve_freq sounds a bit out of this patch
> subject.
Not sure I agree -- if we're going to index the EM table from schedutil
it should be integrated nicely if possible.
Thanks
Powered by blists - more mailing lists