linux-kernel - Re: [PATCH] driver: input: touchscreen: modify Raydium i2c touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQZ30CeO0iFztxRMV3N+ty8bYX-wOLWnyKaDTniBtLaNhjQjA@mail.gmail.com>
Date:   Thu, 15 Apr 2021 10:05:10 -0600
From:   Raul Rangel <rrangel@...omium.org>
To:     "simba.hsu" <simba.hsu@...dium.corp-partner.google.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Furquan Shaikh <furquan@...gle.com>,
        Sean Paul <seanpaul@...omium.org>, simba.hsu@...-ic.com,
        jeffrey.lin@...-ic.com, KP.li@...-ic.com,
        linux-input <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] driver: input: touchscreen: modify Raydium i2c
 touchscreen driver

On Thu, Apr 15, 2021 at 2:58 AM simba.hsu
<simba.hsu@...dium.corp-partner.google.com> wrote:
>
> This path makes auto-update available when IC's status is
> Recovery mode.
>
> Signed-off-by: simba.hsu@...dium.corp-partner.google.com
> Change-Id: I5ae54896a201b949eba7514500a7e75574f5726b
> ---
>  drivers/input/touchscreen/raydium_i2c_ts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
> index 444479ef699e..a97403c55f75 100644
> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
> @@ -298,6 +298,7 @@ static int raydium_i2c_query_ts_BL_info(struct raydium_data *ts)
>                                          0x10, 0xc0, 0x01, 0x00, 0x04, 0x00};
>         int error;
>         u8 rbuf[5] = {0, 0, 0, 0, 0};
> +       u32 tmpdata = 0;
>
>         error = raydium_i2c_send(client,
>                                  RM_CMD_BOOT_WRT, get_hwid, sizeof(get_hwid));
> @@ -315,7 +316,8 @@ static int raydium_i2c_query_ts_BL_info(struct raydium_data *ts)
>         error = raydium_i2c_read(client,
>                                  RM_CMD_BOOT_CHK, rbuf, sizeof(rbuf));
>         if (!error) {
> -               ts->info.hw_ver = cpu_to_le32(rbuf[1]<<24|rbuf[2]<<16|rbuf[3]<<8|rbuf[4]);
> +               tmpdata = (rbuf[1]<<24|rbuf[2]<<16|rbuf[3]<<8|rbuf[4]);
Can you use be32_to_cpup instead?

> +               ts->info.hw_ver = cpu_to_le32(tmpdata);
>                 dev_err(&client->dev, "HWID %08X\n", ts->info.hw_ver);
>         } else {
>                 ts->info.hw_ver = cpu_to_le32(0xffffffffUL);
> --
> 2.25.1
>