linux-kernel - Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Apr 2021 09:47:25 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nicolas Boichat <drinkcat@...omium.org>, matthias.bgg@...nel.org
Cc:     Hsin-Yi Wang <hsinyi@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Fabien Parent <fparent@...libre.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings

Hi Nicolas,

On 15/04/2021 02:29, Nicolas Boichat wrote:
> On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@...nel.org> wrote:
>>
>> From: Matthias Brugger <matthias.bgg@...il.com>
>>
>> The dsi children don't have any reg property,
> 
> Confused, see below.
> 
>> so we don't need address and
>> size cells. This makes dtbs_check happy.
>>
>> CC: Hsin-Yi Wang <hsinyi@...omium.org>
>> CC: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> CC: Nicolas Boichat <drinkcat@...omium.org>
>> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>
>>
>> ---
>>
>>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> index ff56bcfa3370..f4dca6a33168 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> @@ -251,8 +251,7 @@ &cpu7 {
>>
>>  &dsi0 {
>>         status = "okay";
>> -       #address-cells = <1>;
>> -       #size-cells = <0>;
>> +
>>         panel: panel@0 {
>>                 /* compatible will be set in board dts */
>>                 reg = <0>;
> 
> ^^ isn't that... a reg property?
> 

Yes, that's my fault. I'm not quite sure why we would need this reg property. In
any case also we have it present "dtbs_check W=1" throws the following warning:
mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
/soc/dsi@...14000: unnecessary #address-cells/#size-cells without "ranges" or
child "reg" property


Can you have a look at that?

Regards,
Matthias

>> --
>> 2.30.2
>>