linux-kernel - Re: [PATCH v2 2/8] MIPS: pci-rt2880: remove unneeded locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNKnsT8GngwDVrX9HvoGFpqHj-dnWhk_vCkSAhQhdRSbK5_NA@mail.gmail.com>
Date:   Thu, 15 Apr 2021 11:07:24 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Ilya Lipnitskiy <ilya.lipnitskiy@...il.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/8] MIPS: pci-rt2880: remove unneeded locks

On Wed, Apr 14, 2021 at 6:12 AM Ilya Lipnitskiy
<ilya.lipnitskiy@...il.com> wrote:
> Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883:
> Remove odd locking in PCI config space access code"). pci-rt2880 shares
> the driver layout with pci-rt3883 and the same reasons apply.
>
> Caller (generic PCI code) already does proper locking, so no need to add
> another one here. Local PCI read/write functions are never called
> simultaneously, also they do not require synchronization with the PCI
> controller ops, since they are used before the controller registration.
>
> Suggested-by: Sergey Ryazanov <ryazanov.s.a@...il.com>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@...il.com>

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>

-- 
Sergey