linux-kernel - Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Apr 2021 10:18:28 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Jie Deng <jie.deng@...el.com>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        conghui.chen@...el.com, kblaiech@...lanox.com,
        jarkko.nikula@...ux.intel.com,
        Sergey Semin <Sergey.Semin@...kalelectronics.ru>,
        Mike Rapoport <rppt@...nel.org>, loic.poulain@...aro.org,
        Tali Perry <tali.perry1@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        yu1.wang@...el.com, shuo.a.liu@...el.com,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

On Thu, Apr 15, 2021 at 04:15:07PM +0800, Jie Deng wrote:
> On 2021/4/15 15:28, Wolfram Sang wrote:
> 
> > > Now that we were able to catch you, I will use the opportunity to
> > > clarify the doubts I had.
> > > 
> > > - struct mutex lock in struct virtio_i2c, I don't think this is
> > >    required since the core takes care of locking in absence of this.
> > This is likely correct.
> 
> OK. Then I will remove the lock.

Let me have a look first, please.

> > > - Use of I2C_CLASS_DEPRECATED flag, I don't think it is required for
> > >    new drivers.
> > This is definately correct :)
> 
> Do you mean a new driver doesn't need to set the following ?
> 
> vi->adap.class = I2C_CLASS_DEPRECATED;
> 
> Just leave the class to be 0 ?

Yes. DEPRECATED is only for drivers which used to have a class and then
chose to remove it.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)